lkml.org 
[lkml]   [2006]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 19/38] KVM: Make __set_efer() an arch operation
On Mon, Nov 27, 2006 at 12:29:38PM -0000, Avi Kivity wrote:
> #ifdef __x86_64__
> - __set_efer(vcpu, sregs->efer);
> + kvm_arch_ops->set_efer(vcpu, sregs->efer);
> #endif
I think it would be much better to make ->set_efer a noop for 32bit,
and have different operation vectors for 32 vs 64 bit.

> #ifdef __x86_64__
> - __set_efer(vcpu, 0);
> + vmx_set_efer(vcpu, 0);
> #endif

Similarly vmx_set_efer should just become a noop on 32bit.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-27 14:43    [from the cache]
©2003-2011 Jasper Spaans