lkml.org 
[lkml]   [2006]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [2.6 patch] net/sctp/socket.c: add missing sctp_spin_unlock_irqrestore
From
Date
On Sun, 2006-11-26 at 10:12 +0000, Al Viro wrote:
> On Sun, Nov 26, 2006 at 06:00:53PM +0800, Eugene Teo wrote:
> > This patch adds a missing sctp_spin_unlock_irqrestore when returning
> > from "if(space_left<addrlen)" condition.
> > if (copy_to_user(*to, &temp, addrlen)) {
> > - sctp_spin_unlock_irqrestore(&sctp_local_addr_lock,
> > - flags);
> > - return -EFAULT;
> > + err = -EFAULT;
> > + goto unlock;
>
> > + sctp_spin_unlock_irqrestore(&sctp_local_addr_lock, flags);
> > + return err;
> > }
>
> You do realize that it's obviously still badly broken, don't you?
> copy_to_user() under a spinlock is a recipe for deadlock, especially
> if you've got interrupts disabled...
>
> I have a beginning of locking fixes in that shitpile, but it's incomplete
> and bloody painful ;-/
> -

do your patches also remove the empty abstraction of the sctp_ prefix
around the spinlock use in sctp ?


--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-26 11:23    [W:0.033 / U:18.996 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site