lkml.org 
[lkml]   [2006]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Avoid truncating to 'long' in ALIGN() macro
    On Sat, Nov 25, 2006 at 03:05:00PM -0800, David Miller wrote:
    > From: Roland Dreier <rdreier@cisco.com>
    > Date: Sat, 25 Nov 2006 14:56:22 -0800
    >
    > > > Perhaps a better way to fix this is to use
    > > > typeof() like other similar macros do.
    > >
    > > I tried doing
    > >
    > > #define ALIGN(x,a) \
    > > ({ \
    > > typeof(x) _a = (a); \
    > > ((x) + _a - 1) & ~(_a - 1); \
    > > })
    > >
    > > but that won't compile because of <net/neighbour.h>:
    >
    > You would need to also cast the constants with typeof() to.

    Oh, for fsck sake...

    (typeof(x))((x + a - 1) & ~(a - 1ULL))
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-26 02:13    [W:0.021 / U:32.772 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site