lkml.org 
[lkml]   [2006]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] add return value checking of get_user() in set_vesa_blanking()
On Tue, 21 Nov 2006 17:31:15 -0800
Andrew Morton <akpm@osdl.org> wrote:

> On Tue, 21 Nov 2006 14:15:28 +0900
> Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
>
> > Hi,
> >
> > This patch has added return value checking of get_user() in set_vesa_blanking().
> >
> > Yoichi
> >
> > Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> >
> > diff -pruN -X generic/Documentation/dontdiff generic-orig/drivers/char/vt.c generic/drivers/char/vt.c
> > --- generic-orig/drivers/char/vt.c 2006-11-21 10:23:39.409667250 +0900
> > +++ generic/drivers/char/vt.c 2006-11-21 10:11:48.037209250 +0900
> > @@ -3318,9 +3318,10 @@ postcore_initcall(vtconsole_class_init);
> >
> > static void set_vesa_blanking(char __user *p)
> > {
> > - unsigned int mode;
> > - get_user(mode, p + 1);
> > - vesa_blank_mode = (mode < 4) ? mode : 0;
> > + unsigned int mode;
> > +
> > + if (!get_user(mode, p + 1))
> > + vesa_blank_mode = (mode < 4) ? mode : 0;
> > }
> >
> > void do_blank_screen(int entering_gfx)
>
> How about we go all the way?

It's good for us.

Thanks,

Yoichi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-22 06:21    [W:0.034 / U:10.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site