lkml.org 
[lkml]   [2006]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/22] powerpc: convert idle_loop to use hard_irq_disable()
Date
On Tuesday 21 November 2006 01:53, Benjamin Herrenschmidt wrote:
> +
> +       /*
> +        * We need to hard disable interrupts, but we also need to mark them
> +        * hard disabled in the PACA so that the local_irq_enable() done by
> +        * our caller upon return propertly hard enables.
> +        */
> +       hard_irq_disable();
> +       get_paca()->hard_enabled = 0;
> +

Yes, this looks good. Paul, please use this patch instead of mine.
Do we need to do the same thing for any of the other power_save functions?
IIRC, all new CPUs are supposed to use the same mechanism based on the
0x100 vector.

Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-21 11:19    [W:0.054 / U:23.752 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site