lkml.org 
[lkml]   [2006]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [-mm patch] CACHEFILES must depend on PROC_FS
    On Wed, 22 Nov 2006 05:17:36 +0100 Adrian Bunk wrote:

    > I got the following compile error with CONFIG_PROC_FS=n:
    >
    > <-- snip -->
    >
    > ...
    > CC fs/cachefiles/cf-main.o
    > /home/bunk/linux/kernel-2.6/linux-2.6.19-rc5-mm2/fs/cachefiles/cf-main.c: In function 'cachefiles_init':
    > /home/bunk/linux/kernel-2.6/linux-2.6.19-rc5-mm2/fs/cachefiles/cf-main.c:77: error: 'proc_root_fs' undeclared (first use in this function)
    > /home/bunk/linux/kernel-2.6/linux-2.6.19-rc5-mm2/fs/cachefiles/cf-main.c:77: error: (Each undeclared identifier is reported only once
    > /home/bunk/linux/kernel-2.6/linux-2.6.19-rc5-mm2/fs/cachefiles/cf-main.c:77: error: for each function it appears in.)
    > make[3]: *** [fs/cachefiles/cf-main.o] Error 1
    >
    > <-- snip -->
    >
    > This patch adds the missing dependency of CACHEFILES on PROC_FS.
    >
    > Signed-off-by: Adrian Bunk <bunk@stusta.de>
    >
    > --- linux-2.6.19-rc5-mm2/fs/Kconfig.old 2006-11-22 02:48:36.000000000 +0100
    > +++ linux-2.6.19-rc5-mm2/fs/Kconfig 2006-11-22 02:49:01.000000000 +0100
    > @@ -654,6 +654,7 @@ config FSCACHE
    >
    > config CACHEFILES
    > tristate "Filesystem caching on files"
    > + depends on PROC_FS
    > select FSCACHE
    > help
    > This permits use of a mounted filesystem as a cache for other

    I made that same patch (on linux-fsdevel). David Howells replied:

    Randy Dunlap <randy.dunlap@oracle.com> wrote:

    > CACHEFILES uses PROC_FS, so make it a Kconfig depends.

    Thanks, but the new and improved CacheFiles doesn't use procfs as Christoph
    Hellwig objects to such a practice. In any case, Andrew Morton has dropped it
    from -mm as it's now obsolete.


    ---
    ~Randy
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-22 05:41    [W:3.322 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site