lkml.org 
[lkml]   [2006]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2.6.19-rc6 6/6] rtc-omap driver
On Tue, 21 Nov 2006 18:15:42 -0800
David Brownell <david-b@pacbell.net> wrote:

> On Tuesday 21 November 2006 5:19 pm, Andrew Morton wrote:
> > On Mon, 20 Nov 2006 10:28:48 -0800
>
> > > + /* sometimes the alarm wraps into tomorrow */
> > > + if (then < now) {
> >
> > This isn't wraparound-safe. If you have then=0xffffffff and now=0x00000001.
> >
> > Perhaps that can't happen.
>
> Starting in 2037 or whenever, various things will be breaking...
>
> Probably the RTC lib routines should use a time_t, and when that gets
> changed to 64 bits then things like this will be fixed automagically.
> Right now they use "unsigned long".
>
> I suggest Alessandro handle those issues.
>

We could simply (ab)use timer_after() here.

>
> > > +MODULE_AUTHOR("George G. Davis (and others)");
> >
> > Maybe some additional signoffs would be appropirate?
>
> I pinged the MontaVista emails from the original driver; maybe
> they'll send signoffs.
>

OK. Such signoffs are certainly not a DCO _requirement_. If the MV guys
are asleep, no big deal - we trust david-b's assertion.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-22 03:31    [from the cache]
©2003-2011 Jasper Spaans