Messages in this thread | | | Date | Tue, 21 Nov 2006 01:12:33 +0100 | From | Adrian Bunk <> | Subject | Re: [PATCH 2.6.19-rc5-mm2] fs/dlm: fix recursive dependency in Kconfig |
| |
On Mon, Nov 20, 2006 at 03:35:28PM -0800, Randy Dunlap wrote: > On Mon, 20 Nov 2006 18:45:09 +0100 Adrian Bunk wrote: > > > On Mon, Nov 20, 2006 at 12:45:11PM +0100, Stefan Richter wrote: > > >... > > > Anyway. Whatever you chose to do (or already have chosen to do) in > > > fs/dlm/Kconfig, keep in mind that the "select" keyword is presently only > > > poorly supported by the various .config generators and that it forces UI > > > considerations into the Kconfig files which should better not be > > > overloaded with UI issues. Or in other words: It is rather easy to write > > > correct and well-supported Kconfig files if you stick with "depend on", > > > but you get into trouble fast with generous usage of "select". > > > > For variables like NET or INET it doesn't matter in practice whether you > > use "select" or "depends on". But for other variables it makes it really > > hard for users to enable an option if you use "depends on". > > Doing a "select" NET or INET enables a ton of code, which IMO > should be done explicitly, not covertly by a select.
It seems you misunderstood my statement.
Let me try to phrase it differently:
A "depends on INET" is no problem for users since virtually everyone has INET enabled.
But a "depends on IP_SCTP" or a "depends on I2C_ALGOBIT" is a dependency that might create serious problems for users.
> ~Randy
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |