lkml.org 
[lkml]   [2006]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Regard MSRs in lapic_suspend()/lapic_resume()

* Karsten Wiese <fzu@wemgehoertderstaat.de> wrote:

> Read/Write APIC_LVTPC and APIC_LVTTHMR only, if get_maxlvt() returns
> certain values. This is done like everywhere else in
> i386/kernel/apic.c, so I guess its correct. Suspends/Resumes to disk
> fine and eleminates an smp_error_interrupt() here on a K8.
>
> Signed-off-by: Karsten Wiese <fzu@wemgehoertderstaat.de>

nice one! I'm tempted to suggest this for 2.6.19 merge because it causes
the kernel to do less (so it has little risk of breaking something that
is working) ... who knows what happens on certain (older?) APICs when we
try to write back those bogus values.

Acked-by: Ingo Molnar <mingo@elte.hu>

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-18 08:07    [W:0.053 / U:4.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site