lkml.org 
[lkml]   [2006]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: hda-intel - Disable MSI support by default
At Fri, 17 Nov 2006 00:01:25 +0100,
Olivier Nicolas wrote:
>
> Takashi Iwai wrote:
> > At Wed, 15 Nov 2006 14:15:45 -0500,
> > Jeff Garzik wrote:
> >> ACK the pci_intx() calls, NAK the obviously overweight spinlock changes.
> >> The spinlock changes are completely unnecessary. Just look at any
> >> other (non-ALSA) PCI driver. Existing "spin_lock()" is fine for both
> >> PCI shared irq handlers and MSI irq handlers.
> >>
> >> It sounds like you are trying to work around a reentrancy problem that
> >> does not exist.
> >>
> >> Only weird drivers like ps2kbd/mouse or IDE need spin_lock_irqsave(),
> >> where separate interrupt sources call the same function.
> >
> > OK, I revised it, also referring to a similar patch by Yinghai.
> > I think we can simplify the change like below.
> > Olivier, could you test this patch, too?
>
> Applied to 2.6.19-rc6, the module tries MSI but this time no IRQ get
> disabled. The result is equivalent to 2.6.19-rc6

Does it mean that the driver works as expected with this patch?

>
> ALSA sound/pci/hda/hda_intel.c:543: hda_intel: No response from codec,
> disabling MSI...
> hda_codec: Unknown model for AD1988, trying auto-probe from BIOS...
>
>
> Full details:
> http://olivn.trollprod.com/19-rc6/19-rc6-takashi-routeirq1.dmesg
> http://olivn.trollprod.com/19-rc6/19-rc6-takashi-routeirq1.irq

These look OK to me.


thanks,

Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-17 11:59    [W:0.085 / U:12.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site