lkml.org 
[lkml]   [2006]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/20] x86_64: wakeup.S Misc cleanup
Hi!

> o Various cleanups. One of the main purpose of cleanups is that make
> wakeup.S as close as possible to trampoline.S.
>
> o Following are the changes
> - Indentations for comments.
> - Changed the gdt table to compact form and to resemble the
> one in trampoline.S
> - Take the jump to 32bit from real mode using ljmpl. Makes code
> more readable.
> - After enabling long mode, directly take a long jump for 64bit
> mode. No need to take an extra jump to "reach_comaptibility_mode"
> - Stack is not used after real mode. So don't load stack in
> 32 bit mode.
> - No need to enable PGE here.
> - No need to do extra EFER read, anyway we trash the read contents.
> - No need to enable system call (EFER_SCE). Anyway it will be
> enabled when original EFER is restored.
> - No need to set MP, ET, NE, WP, AM bits in cr0. Very soon we will
> reload the original cr0 while restroing the processor state.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>

ACK, minor nitpicks:

> + /* ??? Why I need the accessed bit set in order for this to work? */

Yes, I'd like to know :-).

> + .quad 0x00cf9b000000ffff # __KERNEL32_CS
> + .quad 0x00af9b000000ffff # __KERNEL_CS
> + .quad 0x00cf93000000ffff # __KERNEL_DS

Can we get a comment telling us what to keep it in sync with?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-18 01:23    [from the cache]
©2003-2011 Jasper Spaans