lkml.org 
[lkml]   [2006]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/15] sas_ata: Don't copy aic94xx's sactive to ata_port
    Date

    Since the aic94xx sequencer assigns its own NCQ tags to ATA commands, it
    no longer makes any sense to copy the sactive field in the STP response
    to ata_port->sactive, as that will confuse libata. Also, libata seems
    to be capable of managing sactive on its own.

    The attached patch gets rid of one of the causes of the BUG messages in
    ata_qc_new, and seems to work without problems on an IBM x206m.

    Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
    ---

    drivers/scsi/libsas/sas_ata.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
    index 77860ab..e2650fa 100644
    --- a/drivers/scsi/libsas/sas_ata.c
    +++ b/drivers/scsi/libsas/sas_ata.c
    @@ -105,7 +105,6 @@ static void sas_ata_task_done(struct sas
    dev->sata_dev.sstatus = resp->sstatus;
    dev->sata_dev.serror = resp->serror;
    dev->sata_dev.scontrol = resp->scontrol;
    - dev->sata_dev.ap->sactive = resp->sactive;
    } else if (stat->stat != SAM_STAT_GOOD) {
    ac = sas_to_ata_err(stat);
    if (ac) {
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-11-17 22:07    [W:0.020 / U:91.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site