lkml.org 
[lkml]   [2006]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: hda-intel - Disable MSI support by default


On Fri, 17 Nov 2006, Yinghai Lu wrote:
>
> the fallback path from MSI test to ioapic still not look good.

I don't think there should be a fallback at all.

Let's just:

- keep MSI disabled by default for now, until we know what's really going
on (and we can try enabling it every once in a while in a -rc1, just to
get more information ;)

- when MSI is selected (ie both the HDA driver _and_ the system decides
that MSI is ok), it should just get used. No testing. No fallbacks. No
strange code at all. Just use it.

The whole notion of trying to see if MSI works is very suspect, and likely
fragile. We should never _ever_ "switch" between the two modes. We choose
one mode, and we stick to it.

Eventually, MSI will hopefully be the more robust of the two methods.
Maybe it will take a year. And maybe we'll end up not using MSI on a lot
of the _current_ crop of motherboards. We don't want to carry the "fall
back from MSI to INTx" code around. We just want a flag saying "use MSI"
or "use INTx".

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.071 / U:5.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site