lkml.org 
[lkml]   [2006]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/6] [RFC] Add MMC Password Protection (lock/unlock) support V6
On Fri, Nov 17, 2006 at 09:03:24AM -0400, Anderson Briglia wrote:
> @@ -101,7 +104,7 @@ mmc_start_request(struct mmc_host *host,
> pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
> mmc_hostname(host), mrq->cmd->opcode,
> mrq->cmd->arg, mrq->cmd->flags);
> -
> +

Random whitespace damage; please remove.

> + do {
> + /* we cannot use "retries" here because the
> + * R1_LOCK_UNLOCK_FAILED bit is cleared by subsequent reads
> to

#include <std-mail-wrapping-complaint.h>

> +error:
> + mmc_deselect_cards(card->host);

You don't need to deselect the card prior to releasing the host; in
fact in single card systems, it's better that you don't. That way
you avoid generating lots of select card messages.

> + mmc_card_release_host(card);
> +out:
> + kfree(data_buf);
> +
> + return err;
> +}
> +
> +//EXPORT_SYMBOL(mmc_lock_unlock);

Either export it or don't. There's no point in having a commented out
export.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-17 17:11    [W:0.042 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site