lkml.org 
[lkml]   [2006]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch, -rc6] x86_64: UP build fixes

* Andi Kleen <ak@suse.de> wrote:

> > my hotplug-CPU cleanup patch solves this in a cleaner way: by
> > removing all those #ifdefs as well.
>
> Fine, but I suspect that late in the release it's better to go for
> minimal "obvious" fixes. Later it can then be cleaned up properly.

we are not /that/ late to not apply trivial cleanups. If my patch breaks
anything then it's easy enough to fix it. But 'lets clean this up later'
is bound to be forgotten and puts the onus on the person doing the
cleanups. You yourself have sent more complex partly-cleanup patches
upstream just 2 days ago:

[PATCH for 2.6.19] [8/9] x86_64: Fix vgetcpu when CONFIG_HOTPLUG_CPU is disabled

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-16 14:07    [W:0.038 / U:5.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site