lkml.org 
[lkml]   [2006]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch, -rc6] x86_64: UP build fixes
Date
On Thursday 16 November 2006 10:48, Ingo Molnar wrote:
>
> * Andi Kleen <ak@suse.de> wrote:
>
> > On Thursday 16 November 2006 10:17, Andrew Morton wrote:
> > > On Thu, 16 Nov 2006 10:01:01 +0100
> > > Andi Kleen <ak@suse.de> wrote:
> > >
> > > > +#ifdef CONFIG_HOTPLUG_CPU
> > > > hotcpu_notifier(cpu_vsyscall_notifier, 0);
> > > > +#endif
> > >
> > > this part isn't needed - the definition handles that.
> >
> > Thanks. Updated patch appended.
>
> my hotplug-CPU cleanup patch solves this in a cleaner way: by removing
> all those #ifdefs as well.

Fine, but I suspect that late in the release it's better to go
for minimal "obvious" fixes. Later it can then be cleaned up properly.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-16 11:13    [W:0.035 / U:3.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site