Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [patch, -rc6] x86_64: UP build fixes | Date | Thu, 16 Nov 2006 11:09:37 +0100 |
| |
On Thursday 16 November 2006 10:48, Ingo Molnar wrote: > > * Andi Kleen <ak@suse.de> wrote: > > > On Thursday 16 November 2006 10:17, Andrew Morton wrote: > > > On Thu, 16 Nov 2006 10:01:01 +0100 > > > Andi Kleen <ak@suse.de> wrote: > > > > > > > +#ifdef CONFIG_HOTPLUG_CPU > > > > hotcpu_notifier(cpu_vsyscall_notifier, 0); > > > > +#endif > > > > > > this part isn't needed - the definition handles that. > > > > Thanks. Updated patch appended. > > my hotplug-CPU cleanup patch solves this in a cleaner way: by removing > all those #ifdefs as well.
Fine, but I suspect that late in the release it's better to go for minimal "obvious" fixes. Later it can then be cleaned up properly.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |