lkml.org 
[lkml]   [2006]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch, -rc6] x86_64: UP build fixes
On Thu, 16 Nov 2006 09:48:55 +0100
Ingo Molnar <mingo@elte.hu> wrote:

> +static inline int
> +smp_call_function_single(int cpuid, void (*func) (void *info), void *info,
> + int retry, int wait)
> +{
> + func(info);
> +
> + return 0;
> +}
> +

Given that on SMP the function is called with local interrupts disabled,
I'd suggest that it should be called with local interrupts disabled on UP
as well.

on_each_cpu() does this and one caller (at least) relies upon it
(invalidate_bh_lrus(), iirc).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-16 10:03    [W:0.059 / U:3.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site