Messages in this thread | | | Date | Thu, 16 Nov 2006 18:47:30 -0500 (EST) | Subject | Re: IPv4: ip_options_compile() how can we avoid blowing up on a NULL skb??? | From | David Miller <> |
| |
From: "Jesper Juhl" <jesper.juhl@gmail.com> Date: Thu, 16 Nov 2006 23:34:14 +0100
> So if 'skb' is NULL, the only route I see that doesn't cause a NULL > pointer deref is if (opt != NULL) and at the same time > (opt->is_data != NULL) . Is that guaranteed in any way?
Yes, it is guarenteed, all callers make sure these invariants hold true.
I'm very happy to accept a patch which assert's this using BUG() checks :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |