lkml.org 
[lkml]   [2006]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH]: HVCS char driver janitoring: fix compile warnings
From
Date
On Thu, 2006-11-16 at 14:39 -0600, Linas Vepstas wrote:
> On Thu, Nov 16, 2006 at 11:03:07AM +1100, Michael Ellerman wrote:
> > On Wed, 2006-11-15 at 15:26 -0600, Linas Vepstas wrote:
> > >
> > > This is a non-urgent patch.
> > >
> > > I can't figure out who the upstream maintainer for char drivers
> > > is supposed to be. Can this patch be applied?
> > >
> > > --linas
> > >
> > > This patch removes an pair of irritating compiler warnings:
> > >
> > > drivers/char/hvcs.c:1605: warning: ignoring return value of
> > > sysfs_create_group declared with attribute warn_unused_result
> > > drivers/char/hvcs.c:1639: warning: ignoring return value of
> > > driver_create_file declared with attribute warn_unused_result
> > >
> > > Doing this required moving a big block of code from the bottom
> > > of the file to the top, so as to avoid the need for (irritating)
> > > forward declarations.
> >
> > Can you do the move and the fix as two patches? It's very hard to review
> > in its current form.
>
> Sorry, coming shortly. -- linas

Thanks, new patches look good.

cheers

--
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-11-16 23:39    [W:0.038 / U:40.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site