lkml.org 
[lkml]   [2006]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] hotplug CPU: clean up hotcpu_notifier() use


On Thu, 16 Nov 2006, Ingo Molnar wrote:
>
> the cpu-hotplug related warning is solved by the cleanup below.

I do not believe this is a cleanup, at least not in this kind of form:

> @@ -1777,8 +1775,8 @@ xfs_icsb_init_counters(
> #ifdef CONFIG_HOTPLUG_CPU
> mp->m_icsb_notifier.notifier_call = xfs_icsb_cpu_notify;
> mp->m_icsb_notifier.priority = 0;
> - register_hotcpu_notifier(&mp->m_icsb_notifier);
> #endif /* CONFIG_HOTPLUG_CPU */
> + register_hotcpu_notifier(&mp->m_icsb_notifier);

That's just horrible. Now you "register" that notifier that you've never
actually even initialized.

The new code is a lot worse than the old code at least in this case.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.039 / U:7.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site