[lkml]   [2006]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch 26/30] Char: isicom, fix close bug
-stable review patch.  If anyone has any objections, please let us know.

From: Jiri Slaby <>

[PATCH] Char: isicom, fix close bug

port is dereferenced even if it is NULL. Dereference it _after_ the
check if (!port)... Thanks Eric <> for reporting this.

This fixes

Signed-off-by: Jiri Slaby <>
Signed-off-by: Linus Torvalds <>
Signed-off-by: Chris Wright <>

drivers/char/isicom.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-
+++ linux-
@@ -1062,11 +1062,12 @@ static void isicom_shutdown_port(struct
static void isicom_close(struct tty_struct *tty, struct file *filp)
struct isi_port *port = tty->driver_data;
- struct isi_board *card = port->card;
+ struct isi_board *card;
unsigned long flags;

if (!port)
+ card = port->card;
if (isicom_paranoia_check(port, tty->name, "isicom_close"))

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-11-16 03:57    [W:0.161 / U:4.272 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site