Messages in this thread | | | Date | Wed, 15 Nov 2006 20:49:15 +0000 | From | Alan <> | Subject | Re: [patch] floppy: suspend/resume fix |
| |
On Wed, 15 Nov 2006 21:24:18 +0100 Pavel Machek <pavel@ucw.cz> wrote:
> On Tue 2006-11-14 11:34:21, Lee Revell wrote: > > On Tue, 2006-11-14 at 12:09 +0100, Pavel Machek wrote: > > > Suspending with mounted floppy is a user error. > > > > Huh? How so? > > Floppy is removable, and you are expected to umount removable devices > before suspend.
That seems pretty crude. There are lots of cases where an apparently removable device is/should be preserved properly and left mounted (eg builtin CF).
We really want to be smarter than that - which means the drivers ought to be doing stuff in their suspend/resume paths to figure out if the media changed when really possible (eg IDE removable)
Floppy is probably not too fixable, but calling it a "user error" is insulting - user expectation is reasonable that suspend/resume should just work. The implementation is just rather trickier/nonsensical in this case. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |