lkml.org 
[lkml]   [2006]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: hda-intel - Disable MSI support by default
Linus Torvalds wrote:
> The spec is just so much toilet paper. The ONLY thing that matters is what
> real hardware does. So please please please PLEASE don't start quoting
> specs as a way to "prove your point". It is totally meaningless.

Amen.


> End result: I think that at least for 2.6.19, and at least for the HDA
> sound driver, keeping it disabled by default is the right choice. We
> should probably _also_ make "pci_msi_supported()" just return an error
> (probably by just clearing "pci_msi_enable") for any non-intel host bridge
> for now.

If you update, pci_msi_{enable,supported} then you can -- and should --
revert the HD-audio driver change. Just reviewed the driver, and it
properly checks all the return values from PCI MSI API functions.

(though, HD-audio shouldn't be using IRQF_DISABLED at all, and shouldn't
be using IRQF_SHARED for PCI MSI interrupts)

Though maybe for 2.6.19 the current state of things is at least a stable
state.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-15 19:33    [W:0.094 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site