lkml.org 
[lkml]   [2006]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] genirq: do not mask interrupts by default


On Wed, 15 Nov 2006, Ingo Molnar wrote:
>
> problem is, we dont know /for a fact/ that something is "APIC-edge". We
> only know that the BIOS claims it that it's so.

This is incorrect. We will have _programmed_ the APIC with whatever the
BIOS said in the MP tables, so if we think it's level triggered, it _is_
level triggered.

So I really think that all the arguments for i8259 not wanting replay
weigh equally on level-triggered PCI irq's too.

Now, the one thing that makes me think your approach is the right one is
that it's potentially going to be better performance - if people disable
irq's and the normal case is that no irq will actually happen, then
optimistically not doing anything at all (except marking the irq disabled,
of course) is always good.

However, because it's a semantic change, I _really_ don't want to do it
right now. We're maybe a week away from 2.6.19, and the "ISA irq's don't
work" report is one of the things that is holding things up right now.

So that's why I'd much rather go with Eric's patch for now - because it
keeps the semantics that we've always had.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.203 / U:1.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site