lkml.org 
[lkml]   [2006]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 19/19] CacheFiles: Permit daemon to probe inuseness of a cache file
    Date
    Christoph Hellwig <hch@infradead.org> wrote:

    > Once again a very strong NACK for anything that gets a fd argument as
    > text from userspace.

    Why? Would you rather I passed it in a struct to an ioctl?

    > Also a very strong NACK for use of fget/fget_light from non-core code and
    > exports for either of them.

    Why?

    I could possibly pass the pathname as text, except that (a) the path length
    may exceed PAGE_SIZE and MAXPATHLEN, and (b) doing a full path lookup() is a
    complete waste of time as the daemon already has the directory open on a file
    descriptor, and so effectively has a bookmark to the location that I can use,
    if I can but get hold of it.

    David
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-15 17:15    [W:0.021 / U:30.836 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site