lkml.org 
[lkml]   [2006]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH 1/1] Char: isicom, fix close bug
From
Date
Is there any chance to have this in 2.6.19?

--

isicom, fix close bug

port is dereferenced even if it is NULL. Dereference it _after_ the check
if (!port)... Thanks Eric <ef87@yahoo.com> for reporting this.
[http://bugzilla.kernel.org/show_bug.cgi?id=7527]

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>

---
commit 3b03fd9a68de624866b52b9e9a93d551839c0128
tree 77fff66a8b34516b014e9adbe55a9f1027de14c4
parent 0579e303553655245e8a6616bd8b4428b07d63a2
author Jiri Slaby <jirislaby@gmail.com> Wed, 15 Nov 2006 00:25:30 +0100
committer Jiri Slaby <jirislaby@gmail.com> Wed, 15 Nov 2006 00:25:30 +0100

drivers/char/isicom.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/char/isicom.c b/drivers/char/isicom.c
index e9e9bf3..58c955e 100644
--- a/drivers/char/isicom.c
+++ b/drivers/char/isicom.c
@@ -1062,11 +1062,12 @@ static void isicom_shutdown_port(struct
static void isicom_close(struct tty_struct *tty, struct file *filp)
{
struct isi_port *port = tty->driver_data;
- struct isi_board *card = port->card;
+ struct isi_board *card;
unsigned long flags;

if (!port)
return;
+ card = port->card;
if (isicom_paranoia_check(port, tty->name, "isicom_close"))
return;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-11-15 00:33    [W:0.217 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site