Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: + fix-compat-space-msg-size-limit-for-msgsnd-msgrcv.patch added to -mm tree | Date | Wed, 15 Nov 2006 00:24:24 +0100 |
| |
On Tuesday 14 November 2006 22:22, suzuki wrote: > Does the following change look fine ? > > do_msgsnd() - Accepting the mtype and user space ptr to the mtext. i.e., > > long do_msgsnd(int msqid, long mtype, void __user *mtext, > size_t msgsz, int msgflg); > and, > > do_msgrcv() - accepting the kernel space data ptr to pmtype and user > space ptr to mtext. The caller has to copy the *pmtype back to the user > space. > > i.e., > > long do_msgrcv(int msqid, long *pmtype, void __user *mtext, > size_t msgsz, long msgtyp, int msgflg);
Yes, that looks fine.
> Can we use the kernel space "struct msgbuf" instead of the mtype being > passed explicitly.
That works as well, although it may be a little confusing to have the extra mtext byte of that structure included there, so I'd prefer the first solution.
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |