Messages in this thread | | | Date | Tue, 14 Nov 2006 13:22:26 -0800 | From | suzuki <> | Subject | Re: + fix-compat-space-msg-size-limit-for-msgsnd-msgrcv.patch added to -mm tree |
| |
Hello Arnd, Arnd Bergmann wrote: > On Tuesday 14 November 2006 02:28, suzuki wrote: > >>I left it as such, inorder to avoid the future changes that may come in >>the struct msgbuf -if at all-, which would make us to pass every single >>field as a parameter to do_msgrcv/do_msgsnd. > > > struct msgbuf is part of the kernel ABI and will never change, so that's > no problem at all. Ok.
Does the following change look fine ?
do_msgsnd() - Accepting the mtype and user space ptr to the mtext. i.e.,
long do_msgsnd(int msqid, long mtype, void __user *mtext, size_t msgsz, int msgflg); and,
do_msgrcv() - accepting the kernel space data ptr to pmtype and user space ptr to mtext. The caller has to copy the *pmtype back to the user space.
i.e.,
long do_msgrcv(int msqid, long *pmtype, void __user *mtext, size_t msgsz, long msgtyp, int msgflg);
or
Can we use the kernel space "struct msgbuf" instead of the mtype being passed explicitly.
Thanks,
Suzuki > > Arnd <><
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |