lkml.org 
[lkml]   [2006]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch] fix up generic csum_ipv6_magic function prototype
    From
    Date
    Al Viro <viro@ftp.linux.org.uk> writes:
    >
    > Incidentally, WTF is
    > define SK_CS_CALCULATE_CHECKSUM
    > #ifndef CONFIG_X86_64
    > #define SkCsCalculateChecksum(p,l) ((~ip_compute_csum(p, l)) & 0xffff)
    > #else
    > #define SkCsCalculateChecksum(p,l) ((~ip_fast_csum(p, l)) & 0xffff)
    > #endif
    > in ./drivers/net/sk98lin/h/skdrv1st.h?

    Looks totally bogus. The x86-64 ip_fast_csum is practically identical
    to the i386 version. Someone must have been asleep while reviewing
    that code.

    But AFAIK sk98lin is scheduled for deletion anyways, to be replaced by
    sky*. Probably for good reasons. Hopefully soon.

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-11-13 10:39    [W:0.021 / U:60.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site