Messages in this thread | | | From | (Eric W. Biederman) | Subject | Re: [RFC] [PATCH 2/16] x86_64: Assembly safe page.h and pgtable.h | Date | Mon, 13 Nov 2006 12:27:16 -0700 |
| |
Andi Kleen <ak@suse.de> writes:
> On Monday 13 November 2006 17:28, Vivek Goyal wrote: >> >> This patch makes pgtable.h and page.h safe to include >> in assembly files like head.S. Allowing us to use >> symbolic constants instead of hard coded numbers when >> refering to the page tables. > > Hmm, I think the ULs are probably not needed anyways. What > happens when you just drop them even for C? You shouldn't get any > new warnings i hope.
I don't remember the details anymore but there were problems when I tried by just removing the suffixes. I think they were no warnings or possibly promotion problems.
Using _AC is just about as simple as dropping the suffix and much more maintainable then maintaining multiple definitions.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |