lkml.org 
[lkml]   [2006]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Apple Motion Sensor driver
On 11/13/06, Stelian Pop <stelian@popies.net> wrote:
> Le lundi 13 novembre 2006 à 10:53 -0500, Dmitry Torokhov a écrit :
>
> > > + return IS_ERR(ams_info.kthread) ? -ENODEV : 0;
>
> > Is there a reason why you reporting -ENODEV instead of real error code
> > from kthread_run()?
>
> Euh... :)
>
> Here it comes again:
>

Great :) Now I wonder if I may ask you to change name of the module
option from "mouse" to "joystick" (HP driver uses this name as well)
because its functionality is closer to a joystick than a mouse.

Otherwise you can have my Acked-by for the input part.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-11-13 19:23    [W:0.395 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site