[lkml]   [2006]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch] genapic: optimize & fix APIC mode setup

* Andi Kleen <> wrote:

> On Saturday 11 November 2006 16:14, Ingo Molnar wrote:
> > From: Ingo Molnar <>
> >
> > this patch fixes a couple of inconsistencies/problems i found while
> > reviewing the x86_64 genapic code (when i was chasing mysterious eth0
> > timeouts that would only trigger if CPU_HOTPLUG is enabled):
> >
> > - AMD systems defaulted to the slower flat-physical mode instead
> > of the flat-logical mode. The only restriction on AMD systems
> > is that they should not use clustered APIC mode.
> This will open a race on CPU hotunplug unfortunately (common for multi
> core suspend)

Note that i386 still defaults to logical flat mode, so whatever hotplug
CPU races there are, they need to be fixed! Given how rare CPU hotplug
systems are i have no problem with having these races in the kernel for
a while until it's fixed.

Also, distro kernels enable CPU_HOTPLUG frequently. It is just ugly
beyond recognition to switch the programming of the IRQ hardware on
non-hotplug hardware just because a mostly-software feature (hotplug) is
enabled ...

if hotplug breaks suspend then fix it, dont hack it around (on one
platform) by slowing down the system [and causing other problems] ...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-11-11 16:33    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean