lkml.org 
[lkml]   [2006]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 4/5] mm: add vm_insert_pfn helpler
    Benjamin Herrenschmidt wrote:
    >>+ vma->vm_flags |= VM_PFNMAP;
    >
    >
    > I wouldn't do that here. I would keep that to the caller (and set it
    > before setting the PTE along with a wmb maybe to make sure it's visible
    > before the PTE no ?)

    Oops, good catch. You're right.

    We probably don't need a barrier because we take the ptl lock
    around setting the pte, and the only other readers who care should
    be ones that also take the same ptl lock.

    --
    SUSE Labs, Novell Inc.
    Send instant messages to your online friends http://au.messenger.yahoo.com

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-10 02:45    [W:0.024 / U:394.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site