[lkml]   [2006]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [patch 4/5] mm: add vm_insert_pfn helpler
    Benjamin Herrenschmidt wrote:
    >>+ vma->vm_flags |= VM_PFNMAP;
    > I wouldn't do that here. I would keep that to the caller (and set it
    > before setting the PTE along with a wmb maybe to make sure it's visible
    > before the PTE no ?)

    Oops, good catch. You're right.

    We probably don't need a barrier because we take the ptl lock
    around setting the pte, and the only other readers who care should
    be ones that also take the same ptl lock.

    SUSE Labs, Novell Inc.
    Send instant messages to your online friends

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-10-10 02:45    [W:0.019 / U:91.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site