[lkml]   [2006]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
    On Tue, 03 Oct 2006 10:52:19 UTC, in fa.linux.kernel Ingo Molnar

    >* Andrew Morton <> wrote:
    >> > I don't personally mind the patch, I just wanted to bring that issue
    >> > up.
    >> yup. Perhaps we could add
    >> so that out-of-tree drivers can reliably do their ifdefing.
    >i'd suggest we do something like:
    > #define __PT_REGS
    >so that backportable drivers can do:
    > static irqreturn_t irq_handler(int irq, void *dev_id __PT_REGS)
    >instead of an #ifdef jungle. Older kernel bases can define __PT_REGS in
    >their interrupt.h (or in the backported driver's header, in one place)
    > #ifndef __PT_REGS
    > # define __PT_REGS , struct pt_regs *regs
    > #endif
    >this would minimize the direct impact in the source-code.

    Has this or something like it been sprinkled with penguin pee? I'm
    one of those misguided out-of-tree maintainers. I dont' use pt_regs
    but like warning-free compiles - and a single code module when

    William D Waddington
    "Even bugs...are unexpected signposts on
    the long road of creativity..." - Ken Burtch
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-10-07 20:47    [W:0.022 / U:4.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site