Messages in this thread | | | Date | Thu, 5 Oct 2006 17:59:24 +0400 | From | Alexey Dobriyan <> | Subject | Re: [RFC PATCH] add pci_{request,free}_irq take #3 |
| |
On Wed, Oct 04, 2006 at 09:26:33PM +0000, Frederik Deweerdt wrote: > On Wed, Oct 04, 2006 at 02:33:11PM -0600, Matthew Wilcox wrote: > > On Wed, Oct 04, 2006 at 08:29:38PM +0000, Frederik Deweerdt wrote: > > > I see. Just to be sure that I got the matter right, does the issue boils > > > down to a choice between: > > > > woah, woah, woah, you're getting yourself confused here. > yep :), I clearly missed the point you made there: > http://lkml.org/lkml/2006/10/3/404 > I've re-read it, hope I've got it right this time. > > > > You're looking at what the architectures do here. We're not concerned > > with that, we're concerned with what the device drivers do with whatever > > value the architecture has stuck in pdev->irq. > Not sure I get it still though. Is the issue more than just the location > of the irq validation code? If yes, could you explain what are the > differences between your proposal and Jeff's ? > > Anyway, let me have another try at summing up the issue: > > #1 > - generic irq validation code in include/linux/pci.h > - arch specific irq validation code in include/asm/pci.h > - is_irq_valid() called by pci_request_irq()
s/is_irq_valid/valid_irq/g methinks.
> BTW this is much like it's done for pci_resource_to_user() > > #2 > - generic irq validation code in include/linux/interrupt.h > - arch specific irq validation code in include/asm/interrupt.h > - include/linux/pci.h includes linux/interrupt.h > - is_irq_valid() called by pci_request_irq() - and maybe others? -
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |