Messages in this thread | | | Date | Thu, 5 Oct 2006 15:20:06 +0200 | From | Heiko Carstens <> | Subject | Re: [PATCH] drivers/base: error handling fixes |
| |
> > + for_each_online_cpu(cpu) { > > + sys_dev = get_cpu_sysdev(cpu); > > + rc = topology_add_dev(sys_dev); > > + if (rc) > > + return rc; > > } > > > > register_hotcpu_notifier(&topology_cpu_notifier); > > Shouldn't the added attribute groups be removed again in the failure > case? > > Also, it might be a bit overkill to fail the whole initialization > because of one "bad" cpu. (And the "bad" cpu wouldn't matter if we > could safely remove non-existent groups :)
This is initcall stuff. The only sane reason why this would fail, would be an out of memory situation . If we are that early short on memory, we are in serious trouble anyway. So I doubt it's worth the extra code. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |