lkml.org 
[lkml]   [2006]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] bitmap: separate bitmap parsing for user buffer and kernel buffer
Date
On Wednesday 04 October 2006 18:10, Andrew Morton wrote:
> On Wed, 4 Oct 2006 17:56:30 -0700
> Reinette Chatre <reinette.chatre@linux.intel.com> wrote:
> > + if (is_user) {
> > + if (__get_user(c, buf++))
> > + return -EFAULT;
> > + }
> > + else
> > + c = *buf++;
>
> Is this actually needed? __get_user(kernel_address) works OK and (believe
> it or not, given all the stuff it involves) boils down to a single
> instruction.

We weren't too sure if that'd be true in all kinds of arches and
memory models. If it works for kernel space too, then we can fold
out a lot of code...

Your call, you are the expert :)

--
Inaky
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-05 03:37    [W:0.050 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site