lkml.org 
[lkml]   [2006]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drivers/base: error handling fixes
    On Wed, 4 Oct 2006 09:05:54 -0400,
    Jeff Garzik <jeff@garzik.org> wrote:

    > drivers/base/class:
    > - class_device_rename(): function basically shat itself if anything
    > failed, leaving things in an indeterminant state. If kmalloc() ever
    > failed, it would dereference ERR_PTR(-ENOMEM). Fix a bunch of bugs,
    > over and above sysfs_create_link() error handling.
    >
    > - class_device_add(): add missing sysfs_remove_link() [fix leak] to error path
    > - class_device_add(): handle sysfs_create_link() failure
    >
    > drivers/base/dmapool:
    > - kmalloc() takes a GFP_xxx argument
    > - handle device_create_file() failure
    >
    > drivers/base/platform:
    > - properly handle errors (fix leak-on-err) in platform_bus_init()
    >
    > drivers/base/topology:
    > - return sysfs error via NOTIFY_BAD

    Hm, I already did fixes for some of these which are in -mm / in Greg's
    tree. It would perhaps make sense if you rediffed against one of those
    trees.

    Cornelia
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-04 16:47    [W:0.050 / U:150.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site