Messages in this thread | | | Date | Tue, 3 Oct 2006 22:29:10 +0000 | From | Frederik Deweerdt <> | Subject | Re: [RFC PATCH] add pci_{request,free}_irq take #2 |
| |
> >Index: 2.6.18-mm3/include/linux/interrupt.h > >=================================================================== > >--- 2.6.18-mm3.orig/include/linux/interrupt.h > >+++ 2.6.18-mm3/include/linux/interrupt.h > >@@ -75,6 +75,13 @@ struct irqaction { > > struct proc_dir_entry *dir; > > }; > > +#ifndef ARCH_VALIDATE_PCI_IRQ > >+static inline int is_irq_valid(unsigned int irq) > >+{ > >+ return irq ? 1 : 0; > >+} > >+#endif /* ARCH_VALIDATE_PCI_IRQ */ > > It's not appropriate to have PCI IRQ stuff in linux/interrupt.h. > > This is precisely why I passed 'struct pci_dev *' to a PCI-specific irq validation function, and prototyped it in linux/pci.h. > My bad, I've mixed your proposal and Matthew's, isn't this just a matter of: s/ARCH_VALIDATE_PCI_IRQ/ARCH_VALIDATE_IRQ/ ?
I'll look if there's some non-PCI code that might check the irq's value and thus might benefit from this.
Regards, Frederik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |