Messages in this thread Patch in this message | | | Date | Sun, 29 Oct 2006 18:50:05 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 2.6.18-mm2] acpi: add backlight support to the sony_acpi driver |
| |
Hi!
> > Some whitespace is not okay there... > > Pavel > > updated version.
> index 27597c5..1a18cdb 100644 > --- a/drivers/video/backlight/backlight.c > +++ b/drivers/video/backlight/backlight.c > @@ -190,7 +190,7 @@ static int fb_notifier_callback(struct n > * Creates and registers new backlight class_device. Returns either an > * ERR_PTR() or a pointer to the newly allocated device. > */ > -struct backlight_device *backlight_device_register(const char *name, void *devdata, > +struct backlight_device *backlight_device_register(const char *name,struct device *dev, void *devdata, > struct
80-columns, and fix the whitespace, please.
> --- /dev/null > +++ b/drivers/video/output.c > @@ -0,0 +1,110 @@ > +/* > + * Video output switch support > + */
I guess this one needs copyright/GPL.
> + struct output_device *new_dev; > + int ret_code = 0;
Indentation is wrong where...
> + new_dev = (struct output_device *) kzalloc( sizeof(struct output_device), GFP_KERNEL);
Cast should not be needed.
> + strlcpy(new_dev->class_dev.class_id, name, KOBJ_NAME_LEN); > + class_set_devdata(&new_dev->class_dev, devdata); > + ret_code = class_device_register(&new_dev->class_dev); > + if (ret_code){
") {", please.
> + kfree (new_dev);
..and no space between kfree and its arguments.
> @@ -0,0 +1,27 @@ > +The output sysfs class driver is to provide video output abstract layer that can be used to hook platform specific methods to enable/disable video output device through common sysfs interface. > + 80-columns, please. And some title would be nice.
> @@ -141,11 +144,11 @@ struct acpi_video_device_cap { > u8 _ADR:1; /*Return the unique ID */ > u8 _BCL:1; /*Query list of brightness control levels supported */ > u8 _BCM:1; /*Set the brightness level */ > + u8 _BQC:1; /*Get current brightness level */ > u8 _DDC:1; /*Return the EDID for this device */ > u8 _DCS:1; /*Return status of output device */ > u8 _DGS:1; /*Query graphics state */ > u8 _DSS:1; /*Device state set */
It is nicer to have space between /* and comment. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |