lkml.org 
[lkml]   [2006]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] strstrip remove last blank fix
On Thu, 26 Oct 2006, Michael Holzheu wrote:
> strstrip() does not remove the last blank from strings which only consist
> of blanks.

[snip]

> Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Signed-off-by: Michael Holzheu <holzheu@de.ibm.com>
>
> ---
>
> lib/string.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -Naurp linux-2.6.18/lib/string.c linux-2.6.18-strstrip-fix/lib/string.c
> --- linux-2.6.18/lib/string.c 2006-06-19 14:03:20.000000000 +0200
> +++ linux-2.6.18-strstrip-fix/lib/string.c 2006-10-25 18:36:08.000000000 +0200
> @@ -320,7 +320,7 @@ char *strstrip(char *s)
> return s;
>
> end = s + size - 1;
> - while (end != s && isspace(*end))
> + while (end >= s && isspace(*end))
> end--;
> *(end + 1) = '\0';

Looks good, thanks! Andrew, can you please pick up this patch?

Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-26 13:23    [W:0.031 / U:4.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site