Messages in this thread | | | Date | Thu, 26 Oct 2006 16:53:30 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH cciss: fix printk format warning |
| |
Roland Dreier wrote: > > OK, how about this one then? > > > > c->busaddr = (__u32) cmd_dma_handle; > > > > where cmd_dma_handle is a dma_addr_t (u32 or u64) > > It's super-fishy looking but actually I think it's OK, at least as > things stand now. As you see later from how it's freed: > > > pci_free_consistent(h->pdev, sizeof(CommandList_struct), > > c, (dma_addr_t) c->busaddr); > > this is the bus address of memory from pci_alloc_consistent(), and > since cciss never does pci_set_consistent_dma_mask(), the mask will > remain at the default 32 bits. So the driver is actually safe in > assuming that cmd_dma_handle fits into 32 bits. assuming that > cmd_dma_handle.
Hm, OK. Thanks.
-- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |