Messages in this thread | | | Date | Thu, 26 Oct 2006 14:55:36 +0000 | From | "Miguel Ojeda" <> | Subject | Re: [PATCH 2.6.19-rc1 full] drivers: add LCD support |
| |
On 10/23/06, Franck Bui-Huu <vagabon.xyz@gmail.com> wrote: > On 10/23/06, Miguel Ojeda <maxextreme@gmail.com> wrote: > > Yes, we are sure. AFAIK there is no need to lock when it is a fbdev. > > The older version were "alone" drivers: they needed to lock because > > they used fops and they exported functions. > > > > ok, so no other driver than fb could use 'cfag12864b_buffer'. Maybe > I'm missing something but why did you split your fb driver into > cfag12864b.c and cfag12864fb.c ? >
To be clearer. And you are wrong: you can write other modules which want to know what the LCD is showing, or use it; without worrying about framebuffer things. They can read / write "cfag12864b_buffer" as well as cfag12864bfb do. Why not?
The cfag12864b module is the real driver, which uses ks0108 module. The cfag12864bfb is just the framebuffer device.
> > BTW, 'cfag12864b_cache' could have been static...
Right, I saw that in the meantime I was adding the mmap feature. Thanks.
> > Franck > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |