lkml.org 
[lkml]   [2006]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lkdtm: cleanup headers and module_param/MODULE_PARM_DESC
Hi,

> #include <linux/kernel.h>
> +#include <linux/fs.h>
> #include <linux/module.h>
> +#include <linux/buffer_head.h>
> #include <linux/kprobes.h>
> -#include <linux/kallsyms.h>
> +#include <linux/list.h>
> #include <linux/init.h>
> -#include <linux/irq.h>
> #include <linux/interrupt.h>
> +#include <linux/hrtimer.h>
> #include <scsi/scsi_cmnd.h>

Why does the module require fs.h, hrtimer.h, list.h and buffer_head.h? It works fine for me without these header files. I do not get any gcc warning. Moreover, I found that even init.h and interrupt.h are also not required.

> +MODULE_PARM_DESC(cpoint_name, " Crash Point, where kernel is to be crashed");
> +module_param(cpoint_type, charp, 0644);
> +MODULE_PARM_DESC(cpoint_type, " Crash Point Type, action to be taken on "\
> + "hitting the crash point");
> +module_param(cpoint_count, int, 0644);
> +MODULE_PARM_DESC(cpoint_count, " Crash Point Count, number of times the "\
^^not required now!
> + "crash point is to be hit to trigger action");
>

Thanks for fixing the typo.

> ---
> ~Randy

--
Ankita Garg
Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-26 06:21    [W:0.032 / U:32.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site