lkml.org 
[lkml]   [2006]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix generic WARN_ON message
Hi!

> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
> > A warning is a warning, not a BUG.
>
> > - printk("BUG: warning at %s:%d/%s()\n", __FILE__, \
> > + printk("WARNING at %s:%d %s()\n", __FILE__, \
>
> i'm not really happy about this change.
>
> Firstly, most WARN_ON()s are /bugs/, not warnings ... If it's a real
> warning, a KERN_INFO printk should be done.
>
> Secondly, the reason i changed it to the 'BUG: ...' format is that i
> tried to make it easier for automated tools (and for users) to figure
> out that a kernel bug happened.

Well... but the message is really bad. It leads to users telling us "I
hit BUG in kernel"...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-25 12:07    [W:0.059 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site