lkml.org 
[lkml]   [2006]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/5] netpoll: use sk_buff_head for txq
    From
    From: Stephen Hemminger <shemminger@osdl.org>
    Date: Mon, 23 Oct 2006 12:02:53 -0700

    > + spin_lock_irqsave(&netpoll_txq.lock, flags);
    > + for (skb = (struct sk_buff *)netpoll_txq.next;
    > + skb != (struct sk_buff *)&netpoll_txq; skb = next) {
    > + next = skb->next;
    > + if (skb->dev == dev) {
    > + skb_unlink(skb, &netpoll_txq);
    > + kfree_skb(skb);
    > + }
    > }
    > + spin_unlock_irqrestore(&netpoll_txq.lock, flags);

    IRQ's are disabled, I think we can't call kfree_skb() in such a
    context.

    That's why zap_completion_queue() has all of these funny
    skb->destructor checks and such, all of this stuff potentially runs in
    IRQ context.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-24 08:07    [W:4.203 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site