lkml.org 
[lkml]   [2006]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH] x86_64 irq: reuse vector for set_xxx_irq_affinity in phys flat mode
Date
From
From: ebiederm@xmission.com [mailto:ebiederm@xmission.com] 

>Beyond that I have a few nits to pick with the patch.
>- We duplicate the code that claims a new vector which makes
> maintenance a pain.
>- The comments are specific to phys_flat but the code is not.
>- The test for being able to use the old_vector in the new domain
> should be: ...[old_vector] == vector || ...[old_vector] == -1

Please attached one. This one need to after your patch about irq.

YH

[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2006-10-23 23:03    [W:0.036 / U:0.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site