Messages in this thread | | | Date | Mon, 23 Oct 2006 11:32:51 -0700 | From | Greg KH <> | Subject | Re: Battery class driver. |
| |
On Mon, Oct 23, 2006 at 11:30:48AM -0700, Greg KH wrote: > On Mon, Oct 23, 2006 at 07:20:33PM +0100, David Woodhouse wrote: > > I'm half tempted to ditch the sysfs attributes and just use a single > > seq_file, in fact. > > Ick, no. You should use the hwmon interface, and standardize on a > proper battery api just like those developers have standardized on other > sensor apis that are exported to userspace. Take a look at > Documentation/hwmon/sysfs-interface for an example of what it should > look like.
Ok, nevermind, it looks like your code does do something much like this, which is great. Just make sure your units are the same as the other hwmon drivers and everything should be fine.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |