lkml.org 
[lkml]   [2006]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH -mm] swsusp: Improve handling of highmem
HI!

> Currently swsusp saves the contents of highmem pages by copying them to the
> normal zone which is quite inefficient (eg. it requires two normal pages to be
> used for saving one highmem page). This may be improved by using highmem
> for saving the contents of saveable highmem pages.
...
> include/linux/suspend.h | 9
> kernel/power/power.h | 2
> kernel/power/snapshot.c | 841 ++++++++++++++++++++++++++++++++++++------------
> kernel/power/swap.c | 2
> kernel/power/swsusp.c | 53 +--
> kernel/power/user.c | 2
> mm/vmscan.c | 3

Well, I just hoped that highmem would quietly die out...

...
> +static struct page *alloc_image_page(gfp_t gfp_mask) {
> + struct page *page;

{ should go on new line.

> memory_bm_position_reset(orig_bm);
> memory_bm_position_reset(copy_bm);
> do {
> pfn = memory_bm_next_pfn(orig_bm);
> - if (likely(pfn != BM_END_OF_MAP)) {
> - struct page *page;
> - void *src;
> -
> - page = pfn_to_page(pfn);
> - src = page_address(page);
> - page = pfn_to_page(memory_bm_next_pfn(copy_bm));
> - copy_data_page(page_address(page), src);
> - }
> + if (likely(pfn != BM_END_OF_MAP))
> + copy_data_page(memory_bm_next_pfn(copy_bm), pfn);
> } while (pfn != BM_END_OF_MAP);
> }

While(1) and "if (pfn != BM_END_OF_MAP) { ...break; } ? Why do you
need to test pfn != BM_END_OF_MAP *three* times?

> Index: linux-2.6.18-mm3/mm/vmscan.c
> ===================================================================
> --- linux-2.6.18-mm3.orig/mm/vmscan.c
> +++ linux-2.6.18-mm3/mm/vmscan.c
> @@ -1233,6 +1233,9 @@ out:
> }
> if (!all_zones_ok) {
> cond_resched();
> +
> + try_to_freeze();
> +
> goto loop_again;
> }

What is this?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-10-23 17:07    [W:0.072 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site