lkml.org 
[lkml]   [2006]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: dealing with excessive includes
    Randy Dunlap wrote:
    > Here's about half of checking includers of linux/smp_lock.h to see
    > if they actually use any of its interfaces. (most don't)
    >
    > Yet to do: fs/* and arch/*
    > Built only on x86_64.
    [...]
    > drivers/acpi/osl.c | 1 -
    > drivers/block/acsi_slm.c | 1 -
    > drivers/block/umem.c | 1 -
    > drivers/char/ds1620.c | 1 -
    > drivers/char/dsp56k.c | 1 -
    > drivers/char/dtlk.c | 1 -
    > drivers/char/ec3104_keyb.c | 1 -
    > drivers/char/ftape/zftape/zftape-init.c | 1 -
    > drivers/char/hangcheck-timer.c | 1 -
    > drivers/char/ip27-rtc.c | 1 -
    > drivers/char/lp.c | 1 -
    > drivers/char/mem.c | 1 -
    > drivers/char/mxser.c | 1 -
    > drivers/char/ppdev.c | 1 -
    > drivers/char/sysrq.c | 1 -
    > drivers/char/vc_screen.c | 1 -
    > drivers/char/watchdog/omap_wdt.c | 1 -
    > drivers/char/watchdog/pcwd_usb.c | 1 -
    > drivers/i2c/busses/scx200_acb.c | 1 -
    > drivers/i2c/i2c-dev.c | 1 -
    > drivers/ieee1394/raw1394.c | 1 -
    > drivers/infiniband/ulp/iser/iser_verbs.c | 1 -
    > drivers/input/evdev.c | 1 -
    > drivers/input/input.c | 1 -
    [... etc. pp. ...]
    > sound/oss/swarm_cs4297a.c | 1 -
    > sound/oss/trident.c | 1 -
    > sound/oss/via82cxxx_audio.c | 1 -
    > 166 files changed, 166 deletions(-)
    [...]

    I am afraid in many of these cases a proper cleanup would _replace_ the
    include by the correct one, not just delete it. For example,
    drivers/ieee1394/raw1394.c should include linux/spinlock.h. AFAICS it
    does so at the moment only indirectly via another header.
    --
    Stefan Richter
    -=====-=-==- =-=- =-=--
    http://arcgraph.de/sr/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-10-20 11:29    [W:0.035 / U:1.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site